PKI: Do not set NextUpdate OCSP field when ocsp_expiry is 0 #24192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendpclark
added
bug
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
This was referenced Nov 20, 2023
Merged
Merged
stevendpclark
added a commit
that referenced
this pull request
Nov 20, 2023
* Do not set NextUpdate OCSP field when ocsp_expiry is 0 * Add cl
cognifloyd
pushed a commit
to cognifloyd/vault
that referenced
this pull request
Dec 16, 2023
…p#24192) (hashicorp#24194) * Do not set NextUpdate OCSP field when ocsp_expiry is 0 * Add cl Co-authored-by: Steven Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
ocsp_expiryfield within config/crl is set to 0, we should not be setting theNextUpdatefield within OCSP responses. We were setting it to the current time, which effectively means that the response has expired and shouldn't be used.Based on RFC 6960: 4.2.2.1. Time, we shouldn't have set this field to indicate newer information is available right away