UI: Allow token configuration tune from namespace #24147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
hashishaw
changed the title
hashishaw
commented
Nov 15, 2023
| @@ -32,7 +32,7 @@ export default AuthConfigComponent.extend({ | |||
| data.description = this.model.description; | |||
|
|
|||
| // token_type should not be tuneable for the token auth method. | |||
There was a problem hiding this comment.
This line was instrumental in helping me track this down -- hooray for comments
zofskeez
approved these changes
Nov 15, 2023
|
Build Results: |
This was referenced Nov 15, 2023
This was referenced Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR that fixed this issue only did so for non-namespace token mounts. We didn't realize
ns_tokenwas a token type, so this checks the correct model attribute withns_stripped away