Backport of Audit: eventlogger sink node reopen on SIGHUP into release/1.15.x #23609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/peteski22/audit-sighup-reload/scarcely-civil-orca
branch
2 times, most recently
from
2be8902 to
f34687e
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
peteski22
approved these changes
Oct 11, 2023
…load/scarcely-civil-orca
|
Build Results: |
peteski22
deleted the
backport/peteski22/audit-sighup-reload/scarcely-civil-orca
branch
|
CI Results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #23598 to be assessed for backporting due to the inclusion of the label backport/1.15.x.
The below text is copied from the body of the original PR.
When Vault receives
SIGHUPit iterates a maintained set of reload functions which have responsibility to perform the relevant re-parsing/reconfiguration/reopening of files/Vault/etc.This PR ensures that if an eventlogger sink node (file, syslog, socket) exists within a given audit backend, then it is asked to reopen, rather than interacting with the older (deprecated) way of handling files.
Issue reference: #23596
Note: this PR is currently in draft pending further investigations, but it looks likely this is a bug.
Overview of commits