Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Pre-emptively delete logs dir after cache restore in test-collect-reports #23600

Merged

Conversation

kubawi
Copy link
Contributor

@kubawi kubawi commented Oct 11, 2023

No description provided.

@kubawi kubawi requested a review from ncabatoff October 11, 2023 14:17
@kubawi kubawi self-assigned this Oct 11, 2023
@kubawi kubawi requested a review from a team as a code owner October 11, 2023 14:17
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 11, 2023
@kubawi kubawi requested a review from a team October 11, 2023 14:17
Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the background as to why this might work (you have much more context), but I understand that there's a problem here and trust you :P

All this to say: LGTM!

@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
Failures:

Test Type Package Test Logs
race plugins/database/mssql TestUpdateUser_password view test results
race plugins/database/mssql TestUpdateUser_password/empty_rotation_statements view test results

@kubawi kubawi merged commit 83ae451 into main Oct 11, 2023
116 of 117 checks passed
@kubawi kubawi deleted the kubawi/fix-find-failing-to-delete-dirs-in-test-collect-reports branch October 11, 2023 14:40
marcboudreau pushed a commit that referenced this pull request Oct 11, 2023
…guration (#23547)

* CI: Pre-emptively delete logs dir after cache restore in test-collect-reports (#23600)

* Fix OktaNumberChallenge (#23565)

* remove arg

* changelog

* exclude changelog in verifying doc/ui PRs (#23601)

* Audit: eventlogger sink node reopen on SIGHUP (#23598)

* ensure nodes are asked to reload audit files on SIGHUP

* added changelog

* Capture errors emitted from all nodes during proccessing of audit pipelines (#23582)

* Update security-scan.yml

* Listeners: Redaction only for TCP (#23592)

* redaction should only work for TCP listeners, also fix bug that allowed custom response headers for unix listeners

* fix failing test

* updates from PR feedback

* fix panic when unlocking unlocked user (#23611)

* VAULT-18307: update rotation period for aws static roles on update (#23528)

* add disable_replication_status_endpoints tcp listener config parameter

* add wrapping handler for disabled replication status endpoints setting

* adapt disable_replication_status_endpoints configuration parsing code to refactored parsing code

* refactor configuration parsing code to facilitate testing

* fix a panic when parsing configuration

* update refactored configuration parsing code

* fix merge corruption

* add changelog file

* document new TCP listener configuration parameter

* make sure disable_replication_status_endpoints only has effect on TCP listeners

* use active voice for explanation of disable_replication_status_endpoints

* fix minor merge issue

---------

Co-authored-by: Kuba Wieczorek <[email protected]>
Co-authored-by: Angel Garbarino <[email protected]>
Co-authored-by: Hamid Ghaf <[email protected]>
Co-authored-by: Peter Wilson <[email protected]>
Co-authored-by: Mark Collao <[email protected]>
Co-authored-by: davidadeleon <[email protected]>
Co-authored-by: kpcraig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants