-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add version 1 if KV engine has no version data #23585
Merged
hellobontempo
merged 10 commits into
main
from
ui/VAULT-20811/assume-kv-v1-if-no-version-data
Oct 11, 2023
Merged
UI: Add version 1 if KV engine has no version data #23585
hellobontempo
merged 10 commits into
main
from
ui/VAULT-20811/assume-kv-v1-if-no-version-data
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Oct 10, 2023
Build Results: |
hashishaw
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! an elegant solution ✨
CI Results: |
hellobontempo
deleted the
ui/VAULT-20811/assume-kv-v1-if-no-version-data
branch
October 11, 2023 18:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Used to indicate a potential bug
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
ui
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23463
When a user enables KV in the UI we default to version 2 by passing the version in the
options
object.A kv v1 engine is mounted if no version flag is used when enabling kv using the CLI. This is unclear on the READ request because there is no version information in the
options
key (see below). This PR updates the UI logic so that if no version information exists, the UI assumes it is version 1.