Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable ldap tests for arm #23118

Merged
merged 2 commits into from
Sep 18, 2023
Merged

disable ldap tests for arm #23118

merged 2 commits into from
Sep 18, 2023

Conversation

raymonstah
Copy link
Contributor

This is causing nightly tests to fail on arm64 architecture with:

could not start local LDAP docker container: no port mapping found for 389/tcp

For now, we'll disable them again.

@raymonstah raymonstah requested a review from a team September 15, 2023 19:09
@raymonstah raymonstah marked this pull request as ready for review September 15, 2023 19:09
@raymonstah raymonstah enabled auto-merge (squash) September 15, 2023 19:09
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 15, 2023
@raymonstah raymonstah added this to the 1.16 milestone Sep 15, 2023
@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link

Build Results:
All builds succeeded! ✅

fairclothjm
fairclothjm reviewed Sep 18, 2023
View reviewed changes
changelog/23118.txt
@@ -0,0 +1,3 @@
```release-note:bug
ldaputil: Disable tests for ARM64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a changelog entry for test only changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, think it's worth going back to remove it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you. But I don't think it is necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll just leave it

@raymonstah raymonstah merged commit 6e5bd7a into main Sep 18, 2023
106 checks passed
@raymonstah raymonstah deleted the raymond/disable-ldap-tests-for-arm branch September 18, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fairclothjm fairclothjm fairclothjm approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.16.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@raymonstah @fairclothjm