-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to skip TLS check in acme http-01 challenge #22521
Conversation
Hi @rubroboletus - thanks for the PR! Sorry for the delay here. We've taken a look at this internally:
If you want to take a look at simply skipping TLS verify in the redirect case (removing configuration), we'll accept that PR. If Thanks! |
Hi @kitography, ok, I have removed all the configurable logic and just simply ignore TLS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rubroboletus Thanks for the PR, much appreciated and sorry about the delay getting this merged.
I've added a test case so we don't accidentally break this in the future.
solves #22074 allows to set "tls_skip" on pki acme, which will skip TLS check on acme http-01 challenges.