Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: sets operationNone for a kmip role if no checkboxes are selected into release/1.10.x #19149

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19139 to be assessed for backporting due to the inclusion of the label backport/1.10.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


This PR fixes a kmip role still allowing all operations even if all of the checkboxes are deselected. This is because operation_none was only being set/unset when the blue toggle was clicked (see in gif only after it is toggled, then the operations are removed). But if a user unchecks Allow this role to perform all operations the change does not persist and all operations are still allowed.

This also fixes a typo that made the server operation: Discover versions input render without a checkbox

kmip-role


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-13548/fix-kmip-checkboxes-role-form/trivially-noted-humpback branch from 5a31d62 to 5b0403a Compare February 10, 2023 21:38
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@hellobontempo hellobontempo deleted the backport/ui/VAULT-13548/fix-kmip-checkboxes-role-form/trivially-noted-humpback branch February 10, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants