Kubernetes config validation update #19123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| kubernetesHost: [{ type: 'presence', message: 'Kubernetes host is required' }], | ||
| kubernetesHost: [ | ||
| { | ||
| validator: (model) => (model.disableLocalCaJwt && !model.kubernetesHost ? false : true), |
There was a problem hiding this comment.
Is there a case where the config may be set manually using the CLI, and disabled_local_ca_jwt is true, but then the user wants to come to the UI to edit the config to use the local cluster?
There was a problem hiding this comment.
Yes I think that would be possible. The user would still be able to update the config and add a value for kubernetes_host.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validation was added to the manual config form to require
kubernetes_host, this impacted the inferred config workflow and prevented it from saving. The validator was updated to only requirekubernetes_hostifdisable_local_ca_jwtistrue.