-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update documentation for kubernetes auth method supporting patches to role configuration #17461
base: main
Are you sure you want to change the base?
Conversation
…hes to role configuration
…n create/update endpoint
Just a note, we don't require changelog entries for docs (or testing) updates - only for functional changes to code. :) |
@hsimon-hashicorp I added a changelog entry as it does include a code change. This change just happens to be in a plugin. The related PR from the plugin can be found here: hashicorp/vault-plugin-auth-kubernetes#164 Is there anything more I should take care of before this can be reviewed? |
Hi @hsimon-hashicorp and @tvoran , is there anything else I could do for this PR? I am aware that this ended up being a larger issue regarding a broader misunderstanding of the PUT vs POST requests on plugins. But is there anything blocking the addition for PATCH operations for roles on the Kubernetes auth method (hashicorp/vault-plugin-auth-kubernetes#164)? |
Content updates LGTM, but we should wait to merge this until the corresponding code PR is merged. Feel free to ping me in the comments when that happens and I'll approve. I'm labeling this as "do not merge" in the meantime so it doesn't get merged accidentally. |
PR appears abandoned. It will be closed if there is no new activity by September 8th. |
Hi @schavis, it is no so much abandonned, as waiting for the PR on the plugin side to be reviewed/merged. I can comment on the plugin PR again to see if someone might react, but I tried that already to no avail. |
Thanks for following up! I'll remove the abandoned label so it won't be closed. Since the docs update is blocked on another PR, would you mind marking this as a draft PR until you're ready for a review? |
Relates to: