Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update documentation for kubernetes auth method supporting patches to role configuration #17461

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

f4z3r
Copy link
Contributor

@f4z3r f4z3r commented Oct 7, 2022

@heatherezell
Copy link
Contributor

Just a note, we don't require changelog entries for docs (or testing) updates - only for functional changes to code. :)

@heatherezell heatherezell requested a review from tvoran October 7, 2022 19:03
@f4z3r
Copy link
Contributor Author

f4z3r commented Nov 14, 2022

@hsimon-hashicorp I added a changelog entry as it does include a code change. This change just happens to be in a plugin. The related PR from the plugin can be found here: hashicorp/vault-plugin-auth-kubernetes#164

Is there anything more I should take care of before this can be reviewed?

@f4z3r
Copy link
Contributor Author

f4z3r commented Feb 5, 2023

Hi @hsimon-hashicorp and @tvoran , is there anything else I could do for this PR? I am aware that this ended up being a larger issue regarding a broader misunderstanding of the PUT vs POST requests on plugins. But is there anything blocking the addition for PATCH operations for roles on the Kubernetes auth method (hashicorp/vault-plugin-auth-kubernetes#164)?

@schavis
Copy link
Contributor

schavis commented Aug 17, 2023

Content updates LGTM, but we should wait to merge this until the corresponding code PR is merged. Feel free to ping me in the comments when that happens and I'll approve. I'm labeling this as "do not merge" in the meantime so it doesn't get merged accidentally.

@schavis
Copy link
Contributor

schavis commented Aug 29, 2023

PR appears abandoned. It will be closed if there is no new activity by September 8th.

@schavis schavis added the docs-abandoned Possibly abandoned docs PR. To be closed by content team if no activity from creator after 6 months label Aug 29, 2023
@f4z3r
Copy link
Contributor Author

f4z3r commented Aug 30, 2023

Hi @schavis, it is no so much abandonned, as waiting for the PR on the plugin side to be reviewed/merged. I can comment on the plugin PR again to see if someone might react, but I tried that already to no avail.

@schavis
Copy link
Contributor

schavis commented Aug 30, 2023

Hi @schavis, it is no so much abandonned, as waiting for the PR on the plugin side to be reviewed/merged. I can comment on the plugin PR again to see if someone might react, but I tried that already to no avail.

Thanks for following up! I'll remove the abandoned label so it won't be closed. Since the docs update is blocked on another PR, would you mind marking this as a draft PR until you're ready for a review?

@schavis schavis removed the docs-abandoned Possibly abandoned docs PR. To be closed by content team if no activity from creator after 6 months label Aug 30, 2023
@schavis schavis requested a review from a team August 30, 2023 18:01
@schavis schavis marked this pull request as draft August 31, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants