Update gopsutil to v3 to fix MacOS deprecation warnings #16321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendpclark
approved these changes
Jul 18, 2022
…on in favor of v3 field names
austingebauer
commented
Jul 18, 2022
|
Example of the diff between fields in the Vault host-info response when going from gopsutil v2 to v3.
|
swenson
reviewed
Jul 20, 2022
swenson
reviewed
Jul 20, 2022
swenson
approved these changes
Jul 20, 2022
mpalmi
pushed a commit
that referenced
this pull request
Dec 20, 2022
* Update gopsutil to v3 * Adds v2 field names in host-info response to allow eventual deprecation in favor of v3 field names * Map v3 to v2 field names to keep host-info api compat * copy gopsutil license into source * Bump klog version to fix compilation issues
mpalmi
pushed a commit
that referenced
this pull request
Dec 20, 2022
* Update gopsutil to v3 * Adds v2 field names in host-info response to allow eventual deprecation in favor of v3 field names * Map v3 to v2 field names to keep host-info api compat * copy gopsutil license into source * bump klog version to fix builds
mpalmi
added a commit
that referenced
this pull request
Dec 20, 2022
* update golang/x/net * Update gopsutil to v3 to fix MacOS deprecation warnings (#16321) * Update gopsutil to v3 * Adds v2 field names in host-info response to allow eventual deprecation in favor of v3 field names * Map v3 to v2 field names to keep host-info api compat * copy gopsutil license into source * Bump klog version to fix compilation issues Co-authored-by: Mike Palmiotto <[email protected]> Co-authored-by: Austin Gebauer <[email protected]>
mpalmi
added a commit
that referenced
this pull request
Dec 20, 2022
* update golang/x/net * Update gopsutil to v3 to fix MacOS deprecation warnings (#16321) * Update gopsutil to v3 * Adds v2 field names in host-info response to allow eventual deprecation in favor of v3 field names * Map v3 to v2 field names to keep host-info api compat * copy gopsutil license into source * bump klog version to fix builds Co-authored-by: Mike Palmiotto <[email protected]> Co-authored-by: Austin Gebauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the github.com/shirou/gopsutil dependency to address a build-time deprecation warning in MacOS Monterey (12.0+). This fixes #16062.
Additionally, this brings in a fix from gopsutil/pull/1310 which will allow us to update the
golang.org/x/sysdependency without breaking our OpenBSD releases. I tested that the OpenBSD builds are successful with an updatedgolang.org/x/sysdependency in a separate branch.The CI run looks good, but I plan to do some more testing to ensure this doesn't introduce regressions.
Steps: