Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin multiplexing: add catalog test coverage #14398

Merged
merged 4 commits into from
Mar 8, 2022

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented Mar 7, 2022

Add additional test coverage to the plugin catalog's NewPluginClient method for multiplexed and non-multiplexed plugins. Also add tests for the sdk plugin_client.go.

@vercel vercel bot temporarily deployed to Preview – vault March 7, 2022 22:15 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 7, 2022 22:15 Inactive
Copy link
Contributor

@calvn calvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor nits, but otherwise looks great!

sdk/database/dbplugin/v5/plugin_client_test.go Outdated Show resolved Hide resolved
sdk/database/dbplugin/v5/plugin_client_test.go Outdated Show resolved Hide resolved
vault/plugin_catalog_test.go Outdated Show resolved Hide resolved
vault/plugin_catalog_test.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault March 8, 2022 15:11 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 8, 2022 15:11 Inactive
@fairclothjm fairclothjm merged commit 4d217be into main Mar 8, 2022
@fairclothjm fairclothjm deleted the vault-5108/plugin-mux-tests branch March 8, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants