Backport of Update to raft lib v1.3.3 into release/1.9.x #13753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/upgrade-raft-133/regularly-fine-tuna
branch
from
be69a3c to
fc751cd
Compare
…-fine-tuna # Conflicts: # go.mod # go.sum
hghaf099
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #13703 to be assessed for backporting due to the inclusion of the label backport/1.9.x.
The below text is copied from the body of the original PR.
I have manually tested - with both OSS and ENT - upgrading from a 3-node Vault 1.9.2 cluster to a vault binary including this change. I used the standard minimal-downtime upgrade procedure wherein each standby node is replaced in turn, followed by the leader. After upgrading I verified that vault was healthy by sending a bunch of writes to it and checking the autopilot and leader status endpoints (also via log inspection).
Also note re the changelog entry: we haven't seen any instances of this Raft bug in Vault yet, but Consul has, and we're definitely vulnerable to them in theory.