Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/Remove spinner after token renew #12887

Merged
merged 4 commits into from
Oct 21, 2021
Merged

UI/Remove spinner after token renew #12887

merged 4 commits into from
Oct 21, 2021

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Oct 20, 2021 •
edited
Loading

Successfully removes spinner when token is renewed

renew-token-spinner

@hellobontempo hellobontempo changed the title fixes loading spinner UI/Remove spinner after token renew Oct 20, 2021
@vercel vercel bot temporarily deployed to Preview – vault October 20, 2021 19:27 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 20, 2021 20:30 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 20, 2021 21:00 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 20, 2021 21:00 Inactive
arnav28
arnav28 approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@arnav28 arnav28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hellobontempo hellobontempo merged commit e8e1344 into main Oct 21, 2021
@hellobontempo hellobontempo deleted the ui/renew-token-spinner branch October 21, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnav28 arnav28 arnav28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hellobontempo @arnav28