-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: set namespace within GeneratePasswordFromPolicy #12635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalafut
approved these changes
Sep 25, 2021
tomhjp
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
calvn
added a commit
that referenced
this pull request
Sep 27, 2021
* core: set namespace from the sysview's mount entry on GeneratePasswordFromPolicy * test: update TestDynamicSystemView to be ns-aware, update tests * add changelog entry
calvn
added a commit
that referenced
this pull request
Sep 27, 2021
* core: set namespace from the sysview's mount entry on GeneratePasswordFromPolicy * test: update TestDynamicSystemView to be ns-aware, update tests * add changelog entry
calvn
added a commit
that referenced
this pull request
Sep 27, 2021
* core: set namespace from the sysview's mount entry on GeneratePasswordFromPolicy * test: update TestDynamicSystemView to be ns-aware, update tests * add changelog entry
calvn
added a commit
that referenced
this pull request
Sep 27, 2021
calvn
added a commit
that referenced
this pull request
Sep 27, 2021
calvn
added a commit
that referenced
this pull request
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a change on dynamicSystemView.GeneratePasswordFromPolicy to set a namespace value on its incoming context based on the value that exists on its mount entry.
GeneratePasswordFromPolicy is accessible to plugins via framework.Backend.System(), but callback handlers on the plugin side don't carry over the namespace its context, thus leading to cases where namespace value is not set when called by plugins. The dynamic system view already has visibility into its namespace through its mountEntry so we can just set the context's namespace to the value from there.
Prior to this change, static role credentials rotations would error due to missing namespace information.
Auto-rotation failure:
Manual rotation failure: