Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dep: update vault-plugin-secrets-openldap to v0.3.1 #12597

Merged
merged 3 commits into from
Sep 21, 2021
Merged

dep: update vault-plugin-secrets-openldap to v0.3.1 #12597

merged 3 commits into from
Sep 21, 2021

Conversation

calvn
Copy link
Contributor

@calvn calvn commented Sep 21, 2021 •
edited
Loading

This PR updates vault-plugin-secrets-openldap to v0.3.1 which contains the fix from hashicorp/vault-plugin-secrets-openldap#28

Steps taken:

$ go get github.com/hashicorp/[email protected]

$ go mod vendor && go mod tidy

@calvn calvn added this to the 1.6.7 milestone Sep 21, 2021
@calvn calvn requested review from pcman312 and kalafut September 21, 2021 20:22
@calvn calvn requested a review from taoism4504 as a code owner September 21, 2021 20:22
@calvn calvn requested a review from a team September 21, 2021 20:22
@vercel
Copy link

vercel bot commented Sep 21, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

vault – ./website

🔍 Inspect: https://vercel.com/hashicorp/vault/CL2LN19SQSQEPCUtDZTzLDvMGCVS
✅ Preview: Canceled

[Deployment for abcf580 canceled]

vault-storybook – ./ui

🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/37J1V774KpCTYWiL8aDkPMxN6tnb
✅ Preview: Canceled

[Deployment for abcf580 canceled]

@calvn calvn changed the base branch from main to release/1.6.x September 21, 2021 20:22
@calvn calvn changed the title dep: update secrets openldap 1.6.x dep: update vault-plugin-secrets-openldap to v0.3.1 Sep 21, 2021
@vercel vercel bot temporarily deployed to Preview – vault September 21, 2021 21:01 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 21, 2021 21:01 Inactive
@vercel vercel bot temporarily deployed to Preview – vault September 21, 2021 21:11 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 21, 2021 21:11 Inactive
benashz
benashz approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Didn't realize we still vendor'd vault.

@calvn
Copy link
Contributor Author

calvn commented Sep 21, 2021

Yeah, for 1.6.x and 1.7.x we still had the vendor/ directory.

@calvn
Copy link
Contributor Author

calvn commented Sep 21, 2021

Merging this one. The test failure is around the activity log and is a known to occur on this release branch.

@calvn calvn merged commit 0de5cbb into release/1.6.x Sep 21, 2021
@calvn calvn deleted the dep-update-secrets-openldap-1.6.x branch September 21, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

@tvoran tvoran tvoran approved these changes

@pcman312 pcman312 Awaiting requested review from pcman312

@kalafut kalafut Awaiting requested review from kalafut

@taoism4504 taoism4504 Awaiting requested review from taoism4504

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.7
Development

Successfully merging this pull request may close these issues.
3 participants
@calvn @tvoran @benashz