Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Add support for DSA signature verification for EC2 (#12340) #12361

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Backport: Add support for DSA signature verification for EC2 (#12340) #12361

merged 3 commits into from
Aug 20, 2021

Conversation

jasonodonnell
Copy link
Contributor

  • creds/aws: import pkcs7 verification package

  • Add DSA support

  • changelog

  • Add DSA to correct verify function

  • Remove unneeded tests

  • Fix backend test

  • Update builtin/credential/aws/pkcs7/README.md

Co-authored-by: Calvin Leung Huang [email protected]

  • Update builtin/credential/aws/path_login.go

Co-authored-by: Calvin Leung Huang [email protected]

Co-authored-by: Calvin Leung Huang [email protected]

@jasonodonnell @calvn
creds/aws: Add support for DSA signature verification for EC2 (#12340)
054e4fd 
* creds/aws: import pkcs7 verification package

* Add DSA support

* changelog

* Add DSA to correct verify function

* Remove unneeded tests

* Fix backend test

* Update builtin/credential/aws/pkcs7/README.md

Co-authored-by: Calvin Leung Huang <[email protected]>

* Update builtin/credential/aws/path_login.go

Co-authored-by: Calvin Leung Huang <[email protected]>

Co-authored-by: Calvin Leung Huang <[email protected]>
@jasonodonnell jasonodonnell added this to the 1.8.2 milestone Aug 19, 2021
@jasonodonnell jasonodonnell requested review from kalafut, calvn and a team August 19, 2021 13:45
@vercel vercel bot temporarily deployed to Preview – vault August 20, 2021 15:32 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook August 20, 2021 15:32 Inactive
@vercel vercel bot temporarily deployed to Preview – vault August 20, 2021 20:42 Inactive
@jasonodonnell jasonodonnell merged commit 407532f into release/1.8.x Aug 20, 2021
@jasonodonnell jasonodonnell deleted the backport-pr-12340-1.8.x branch August 20, 2021 21:04
@maths22 maths22 mentioned this pull request Sep 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fairclothjm fairclothjm fairclothjm approved these changes

@calvn calvn calvn approved these changes

@kalafut kalafut Awaiting requested review from kalafut

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
1.8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonodonnell @calvn @fairclothjm