Update github.com/ulikunitz/xz

[tsaarni]

• Bump xz which is transitive dependency of github.com/mholt/archiver.
  Fixes known security vulnerability GHSA-25xm-hr59-7c27 Upgrade github.com/ulikunitz/xz to v0.5.8 #9914

[pmmukh]

one minor comment, otherwise lgtm, and thanks for submitting the PR!

[tsaarni]

@pmmukh Two tests fail connection_producer_test.go:43: Could not start docker cassandra. This seems like possible flake. Is it possible to re-trigger those two test cases?

[pmmukh]

ah yep, those are flaky tests, will give em a rerun!

[tsaarni]

The test seems to fail consistently now, also on my machine. Test is using bitnami/cassandra:latest which has been updated to cassandra 4.0 and startup is now much slower.

I submitted a question if this is to be expected https://github.com/bitnami/bitnami-docker-cassandra/issues/98

[tsaarni]

The test seems to fail consistently now, also on my machine. Test is using bitnami/cassandra:latest which has been updated to cassandra 4.0 and startup is now much slower.

I've now merged main to pick up #12311 which I missed in this PR. It forces fixed version bitnami/cassandra:3.11 instead of bitnami/cassandra:latest, so tests should now pass.

Another alternative that worked for me locally, even with bitnami/cassandra:4.0, would be to increase this timeout

diff --git a/helper/testhelpers/docker/testhelpers.go b/helper/testhelpers/docker/testhelpers.go
index 673a0dea7..90698e323 100644
--- a/helper/testhelpers/docker/testhelpers.go
+++ b/helper/testhelpers/docker/testhelpers.go
@@ -146,7 +146,7 @@ func (d *Runner) StartService(ctx context.Context, connect ServiceAdapter) (*Ser

        bo := backoff.NewExponentialBackOff()
        bo.MaxInterval = time.Second * 5
-       bo.MaxElapsedTime = time.Minute
+       bo.MaxElapsedTime = 2 * time.Minute

        pieces := strings.Split(hostIPs[0], ":")
        portInt, err := strconv.Atoi(pieces[1])

but I'm still unsure if this long startup time of new cassandra is to be expected or bug.

[pmmukh]

@tsaarni thanks for looking into that cassandra startup time issue! For the purposes of this PR, I'm going to merge this in and ignore that, I think as far as upgrading Cassandra tests to support cassandra 4, the ecosystem team will be taking a look at that later. Also, if your open issue there reaches a conclusion that some change in Vault can allow us to run tests against cassandra 4, please feel free to open a PR!