-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ldap] auth method fix request_timeout #11975
Conversation
Manual TestsSetupFirst, navigate to the git checkout ldap-request-timeout
make docker-dev Next, from the git checkout ldap-local-docker-dev
cd users/jodonnell/ldap-auth-example Next, run the startup script with the ./run.sh dev Export env vars: export VAULT_ADDR="http://localhost:8200"
export VAULT_TOKEN="root" Testvault auth enable ldap
vault read auth/ldap/config # request_timeout is 90, the default
vault write auth/ldap/config timeout_request=29
vault read auth/ldap/config # request_timeout is 29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments, but looking good! PasswordlessMap()
is called on config read, so I think that we were always storing request_timeout
, just not returning it back.
Co-authored-by: Calvin Leung Huang <[email protected]>
Co-authored-by: Calvin Leung Huang <[email protected]>
Co-authored-by: Calvin Leung Huang <[email protected]>
Description
This PR fixes a bug where the LDAP auth method does not implement the
request_timeout
configuration parameter, neither storing it, nor enforcing it for connections made to an LDAP server.