Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/expiration: Add backoff jitter to the expiration retries #10937

Merged
merged 1 commit into from
Feb 19, 2021
Merged

core/expiration: Add backoff jitter to the expiration retries #10937

merged 1 commit into from
Feb 19, 2021

Conversation

briankassouf
Copy link
Contributor

@briankassouf briankassouf commented Feb 18, 2021 •
edited
Loading

Allow retry backoff time to be a random value between 2^n +/- (0.5*2^n)

Example Backoff:

Attempt  0
	 new:  14.360669943s
	 existing:  10s
Attempt  1
	 new:  27.304622311s
	 existing:  20s
Attempt  2
	 new:  33.817540175s
	 existing:  40s
Attempt  3
	 new:  1m32.140496807s
	 existing:  1m20s
Attempt  4
	 new:  2m38.33880368s
	 existing:  2m40s
Attempt  5
	 new:  7m16.455974504s
	 existing:  5m20s
Attempt  6
	 new:  10m51.998922445s
	 existing:  10m40s

@briankassouf briankassouf added this to the 1.7 milestone Feb 18, 2021
@briankassouf briankassouf merged commit 88d8d18 into master Feb 19, 2021
@briankassouf briankassouf deleted the fairshare-backoff branch February 19, 2021 04:20
catsby added a commit that referenced this pull request Feb 19, 2021
@catsby
Merge branch 'master' into f-bundle-plugin-secrets-terraform
1d90dad 
* master:
  Adds API docs for max_age role parameter of JWT/OIDC auth method (#10916)
  UI/Database Secrets Engine cleanup (#10949)
  helper/metricsutil: Prevent potential Ticker leak (#10913)
  core/expiration: Add backoff jitter to the expiration retries (#10937)
  Revert "Vault Dependency Upgrades [VAULT-871] (#10903)" (#10939)
  Vault Dependency Upgrades [VAULT-871] (#10903)
  Add docs for Agent's template_retry option added in #10644, based on those from consul-template configuration.  Also fix some existing config docs that weren't adhering to our conventions. (#10911)
  UI Database Secrets Engine (MongoDB) (#10655)
  OpenAPI - Don't panic if field isn't found (#10929)
  Vault-1403 Switch Expiration Manager to use Fairsharing Backpressure (#1709) (#10932)
  Update KV Secrets Engine index (#10933)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgritter mgritter mgritter approved these changes

@swayne275 swayne275 Awaiting requested review from swayne275

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
2 participants
@briankassouf @mgritter