-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/managed namespace changes #10588
UI/managed namespace changes #10588
Conversation
…ce without permission
…ion call to vault-config endpoint (mocked)
… managed root namespace set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work so far!
ui/app/services/config.js
Outdated
@@ -0,0 +1,9 @@ | |||
import Service from '@ember/service'; | |||
|
|||
export default Service.extend({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With octane you should be able to start writing these as Native classes (however, ignore me if we have to backport to prior to 1.7).
ex:
import Service from '@ember/service';
export default class ShoppingCartService extends Service {
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, however we do indeed have to backport this to prior to 1.7 😭
…or feature-flags on shamir test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
These changes include:
When a root namespace is retrieved from endpoint and no namespace param is present, redirect: