Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Log child token/lease revocations #4156

Closed
Capitrium opened this issue Mar 19, 2018 · 0 comments
Closed

Feature Request: Log child token/lease revocations #4156

Capitrium opened this issue Mar 19, 2018 · 0 comments
Milestone
0.10

Comments

@Capitrium
Copy link

Feature Request:
Log child token/lease revocations when the parent token expires.

Environment:

  • Vault Version: 0.9.4
  • Operating System/Architecture: CoreOS 1632.3.0 (Host) / Alpine Linux v3.7 (Container)

Expected Behavior:
It would be helpful if Vault logged something when child leases are revoked due to a parent token expiring, i.e. debugging issues with token hierarchies and orphan tokens.

Actual Behavior:
Vault logs only the revocation of the parent token. There are no logs (or audit logs) indicating child tokens are also being revoked.

2018/03/16 23:50:34.931579 [INFO ] expiration: revoked lease: lease_id=auth/kubernetes/login/1d153349b5b742f17b343c971e560062590ab0ca

References:
@jefferai jefferai added this to the 0.10 milestone Mar 19, 2018
jefferai added a commit that referenced this issue Mar 20, 2018
@jefferai
Log revocations in revokeCommon rather than expireID
456b9f4 
Revocations that happen not as a result of direct expirations will
therefore be logged

Fixes #4156
@jefferai jefferai mentioned this issue Mar 20, 2018
Merged
jefferai added a commit that referenced this issue Mar 20, 2018
@jefferai
Log revocations in revokeCommon rather than expireID (#4164)
6d0a24f 
Revocations that happen not as a result of direct expirations will
therefore be logged

Fixes #4156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10
Development

No branches or pull requests
2 participants
@jefferai @Capitrium