Skip to content

Commit

Permalink
address review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
vishalnayak committed Sep 25, 2018
1 parent e3fa27f commit fdc5648
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions vault/identity_store_entities.go
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ func (i *IdentityStore) pathEntityIDDelete() framework.OperationFunc {
return nil, err
}
if entity.NamespaceID != ns.ID {
return nil, logical.ErrUnsupportedPath
return nil, nil
}

// Delete all the aliases in the entity. This function will also remove
Expand Down Expand Up @@ -481,7 +481,7 @@ func (i *IdentityStore) pathEntityNameDelete() framework.OperationFunc {
return nil, err
}
if entity.NamespaceID != ns.ID {
return nil, logical.ErrUnsupportedPath
return nil, nil
}

// Delete all the aliases in the entity. This function will also remove
Expand Down
2 changes: 1 addition & 1 deletion vault/identity_store_groups.go
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ func (i *IdentityStore) handleGroupDeleteCommon(ctx context.Context, key string,
return nil, err
}
if group.NamespaceID != ns.ID {
return nil, logical.ErrUnsupportedPath
return nil, nil
}

// Delete group alias from memdb
Expand Down

0 comments on commit fdc5648

Please sign in to comment.