Skip to content

Commit

Permalink
PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Brian Kassouf committed May 4, 2017
1 parent 9e28b03 commit c825362
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion builtin/logical/database/path_roles.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func pathRoles(b *databaseBackend) *framework.Path {
},
"rollback_statements": {
Type: framework.TypeString,
Description: `SQL statements to be executed to revoke a user. Must be a semicolon-separated
Description: `Statements to be executed to revoke a user. Must be a semicolon-separated
string, a base64-encoded semicolon-separated string, a serialized JSON string
array, or a base64-encoded serialized JSON string array. The '{{name}}' value
will be substituted.`,
Expand Down
4 changes: 2 additions & 2 deletions helper/builtinplugins/builtin.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ var plugins map[string]BuiltinFactory = map[string]BuiltinFactory{
// These four plugins all use the same mysql implementation but with
// different username settings passed by the constructor.
"mysql-database-plugin": mysql.New(mysql.DisplayNameLen, mysql.UsernameLen),
"aurora-database-plugin": mysql.New(mysql.LegacyDisplayNameLen, mysql.LegacyUsernameLen),
"rds-database-plugin": mysql.New(mysql.LegacyDisplayNameLen, mysql.LegacyUsernameLen),
"mysql-aurora-database-plugin": mysql.New(mysql.LegacyDisplayNameLen, mysql.LegacyUsernameLen),
"mysql-rds-database-plugin": mysql.New(mysql.LegacyDisplayNameLen, mysql.LegacyUsernameLen),
"mysql-legacy-database-plugin": mysql.New(mysql.LegacyDisplayNameLen, mysql.LegacyUsernameLen),

"postgresql-database-plugin": postgresql.New,
Expand Down
2 changes: 1 addition & 1 deletion logical/system_view.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ type SystemView interface {
// name. Returns a PluginRunner or an error if a plugin can not be found.
LookupPlugin(string) (*pluginutil.PluginRunner, error)

// MlockEnabled returns the configuration setting for Enableing mlock on
// MlockEnabled returns the configuration setting for enabling mlock on
// plugins.
MlockEnabled() bool
}
Expand Down
6 changes: 3 additions & 3 deletions website/source/docs/secrets/databases/mysql-maria.html.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ description: |-

# MySQL/MariaDB Database Plugin

Name: `mysql-database-plugin`, `aurora-database-plugin`, `rds-database-plugin`,
Name: `mysql-database-plugin`, `mysql-aurora-database-plugin`, `mysql-rds-database-plugin`,
`mysql-legacy-database-plugin`

The MySQL Database Plugin is one of the supported plugins for the Database
Expand All @@ -24,8 +24,8 @@ the length of usernames generated by the plugin as different versions of mysql
accept different lengths. The availible plugins are:

- mysql-database-plugin
- aurora-database-plugin
- rds-database-plugin
- mysql-aurora-database-plugin
- mysql-rds-database-plugin
- mysql-legacy-database-plugin

## Quick Start
Expand Down

0 comments on commit c825362

Please sign in to comment.