Create audit failure metrics unconditionally (#3937)

hashicorp · Feb 7, 2018 · 4a0d3f6 · 4a0d3f6
1 parent b020d31
commit 4a0d3f6
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/vault/audit.go b/vault/audit.go
@@ -525,10 +525,11 @@ func (a *AuditBroker) LogRequest(ctx context.Context, auth *logical.Auth, req *l
 		}
 
 		ret = retErr.ErrorOrNil()
-
+		failure := float32(0.0)
 		if ret != nil {
-			metrics.IncrCounter([]string{"audit", "log_request_failure"}, 1.0)
+			failure = 1.0
 		}
+		metrics.IncrCounter([]string{"audit", "log_request_failure"}, failure)
 	}()
 
 	// All logged requests must have an identifier
@@ -588,9 +589,11 @@ func (a *AuditBroker) LogResponse(ctx context.Context, auth *logical.Auth, req *
 
 		ret = retErr.ErrorOrNil()
 
+		failure := float32(0.0)
 		if ret != nil {
-			metrics.IncrCounter([]string{"audit", "log_response_failure"}, 1.0)
+			failure = 1.0
 		}
+		metrics.IncrCounter([]string{"audit", "log_response_failure"}, failure)
 	}()
 
 	headers := req.Headers