VC: add spec.timeout for Vault requests #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benashz
force-pushed
the
VAULT-28999/vc-add-connection-timeout-et-al-support
branch
from
d15513a
to
a9c1a06
Compare
benashz
force-pushed
the
VAULT-28999/vc-add-connection-timeout-et-al-support
branch
from
a9c1a06
to
d37386a
Compare
Extends the VaultConnection API to include the support for setting the Vault request time. It will be applied to all Vault Clients for the given VaultConnection.
benashz
force-pushed
the
VAULT-28999/vc-add-connection-timeout-et-al-support
branch
from
d37386a
to
f7f5378
Compare
* Fix: encryption client deadlocking the factory Setting up the storage encryption client deadlocks the client factory if the client is deemed to be invalid. This causes all reconciliations to block forever. The fix is to move the client setup code out of storageEncryptionClient(). This gets rid of the vestigial recursive call to itself and allows for single locker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the VaultConnection API to include the support for setting the Vault request time. It will be applied to all Vault Clients for the given VaultConnection.