Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm: adds values for setting VSO's logging options #778

Merged
merged 2 commits into from
May 27, 2024
Merged

Helm: adds values for setting VSO's logging options #778

merged 2 commits into from
May 27, 2024

Conversation

benashz
Copy link
Collaborator

@benashz benashz commented May 27, 2024

Adds the ability to specify various logging parameters that can be set at VSO controller-manager runtime:

Examples:

controller:
  manager:
    # logging
    logging:
      # Sets the log level for the operator.
      # Builtin levels are: info, error, debug, debug-extended, trace
      # @type: string
      level: info

      # Sets the time encoding for the operator.
      # Options are: epoch, millis, nano, iso8601, rfc3339, rfc3339nano
      # Default: rfc3339
      # @type: string
      timeEncoding: rfc3339

      # Sets the stacktrace level for the operator.
      # Options are: info, error, panic
      # Default: panic
      # @type: string
      stacktraceLevel: panic

@benashz benashz requested a review from a team as a code owner May 27, 2024 19:10
@benashz benashz force-pushed the VAULT-26366/optionally-log-stacktrace-on-panic branch from 3d5f422 to f1ef543 Compare May 27, 2024 19:11
@benashz benashz requested a review from thyton May 27, 2024 19:11
@benashz benashz changed the title Adds values for setting VSO's logging options Helm: adds values for setting VSO's logging options May 27, 2024
@benashz benashz added this to the v0.7.0 milestone May 27, 2024
@benashz benashz force-pushed the VAULT-26366/optionally-log-stacktrace-on-panic branch from f1ef543 to 4542c56 Compare May 27, 2024 19:20
thyton
thyton approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@thyton thyton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice tests!

@benashz benashz merged commit bc96a02 into main May 27, 2024
38 checks passed
@benashz benashz deleted the VAULT-26366/optionally-log-stacktrace-on-panic branch May 27, 2024 19:58
@benashz benashz mentioned this pull request May 28, 2024
Closed
benashz added a commit that referenced this pull request May 29, 2024
@benashz
Fix invalid value name
862d4c3 
Corrects an issue introduced in #778
@benashz benashz mentioned this pull request May 29, 2024
Merged
benashz added a commit that referenced this pull request May 29, 2024
@benashz
Fix invalid value name
142907f 
Corrects an issue introduced in #778
benashz added a commit that referenced this pull request May 29, 2024
@benashz
Helm: fix invalid value name for telemetry.serviceMonitor.enabled (#786)
21b17f6 
Corrects an issue introduced in #778
benashz added a commit that referenced this pull request May 30, 2024
@benashz
Helm: fix invalid value name for telemetry.serviceMonitor.enabled (#786)
93522a1 
Corrects an issue introduced in #778
@benashz benashz mentioned this pull request May 30, 2024
Merged
benashz added a commit that referenced this pull request May 30, 2024
@benashz
Helm: fix invalid value name for telemetry.serviceMonitor.enabled (#786…
5eddd06 
…) (#790)

Corrects an issue introduced in #778
benashz added a commit that referenced this pull request Jul 10, 2024
@benashz
Merge release/v0.7.x branch (#794)
caca26c 
* Helm: fix invalid value name for telemetry.serviceMonitor.enabled (#786) (#790)

Corrects an issue introduced in #778

* Update changelog for v0.7.1 (#791)

Cherry pick: #783

* CI: add release/* branches (#792)

* Bump versions (#793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvoran tvoran tvoran left review comments

@thyton thyton thyton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@benashz @tvoran @thyton