Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable development logger mode by default #751

Merged

Conversation

benashz
Copy link
Collaborator

@benashz benashz commented May 14, 2024

Disables the "development" zap log options by default. Now all log lines will be structured e.g:

{"level":"info","ts":"2024-05-14T20:53:26Z","logger":"controller-runtime.metrics","msg":"Shutting down metrics server with timeout of 1 minute"}
{"level":"info","ts":"2024-05-14T20:53:26Z","msg":"shutting down server","name":"health probe","addr":"[::]:8081"}
{"level":"info","ts":"2024-05-14T20:53:26Z","msg":"Wait completed, proceeding to shutdown the manager"}

To enable the old logging behavior VSO should be started with the environment variable VSO_LOGGER_DEVELOPMENT_MODE set to a non-empty value.

@benashz benashz requested a review from a team as a code owner May 14, 2024 19:58
@benashz benashz force-pushed the VAULT-26366/core-logging-make-development-mode-optional branch from 1dcf7e1 to 9ed9be9 Compare May 14, 2024 20:53
@benashz benashz force-pushed the VAULT-26366/core-logging-make-development-mode-optional branch from 9ed9be9 to 38935ec Compare May 14, 2024 21:06
@benashz benashz merged commit 5b0a602 into main May 15, 2024
38 checks passed
@benashz benashz deleted the VAULT-26366/core-logging-make-development-mode-optional branch May 15, 2024 19:19
@benashz benashz added this to the v0.7.0 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants