Work around Vault DB static creds TTL rollover bug #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benashz
force-pushed
the
VAULT-26529/vds-work-around-scheduled-static-creds-ttl-rollover
branch
from
498d725
to
0115e07
Compare
When syncing database static credentials role configured with scheduled rotation, the TTL is incorrectly rolled over within the same rotation period. Since, VSO relies on the TTL for its sync scheduling, an invalid TTL results in syncing stale credentials. This fix, attempts to detect the TTL rollover bug, and ensure that current rotated creds are properly synced.
benashz
force-pushed
the
VAULT-26529/vds-work-around-scheduled-static-creds-ttl-rollover
branch
from
0115e07
to
5d6bb40
Compare
…-creds-ttl-rollover
tvoran
approved these changes
May 10, 2024
benashz
force-pushed
the
VAULT-26529/vds-work-around-scheduled-static-creds-ttl-rollover
branch
from
fa31cba
to
145b47a
Compare
benashz
force-pushed
the
VAULT-26529/vds-work-around-scheduled-static-creds-ttl-rollover
branch
from
3a4ba37
to
3ae0af3
Compare
benashz
force-pushed
the
VAULT-26529/vds-work-around-scheduled-static-creds-ttl-rollover
branch
from
3ae0af3
to
cd70823
Compare
benashz
deleted the
VAULT-26529/vds-work-around-scheduled-static-creds-ttl-rollover
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When syncing database static credentials role configured with scheduled rotation, the TTL is incorrectly rolled over within the same rotation period. Since, VSO relies on the TTL for its sync scheduling, an invalid TTL results in syncing stale credentials.
This fix, attempts to detect the TTL rollover bug, and ensure that current rotated creds are properly synced.