Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPS: return an error when the PKI secret is nil #636

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

benashz
Copy link
Collaborator

@benashz benashz commented Mar 4, 2024

Guard against unmarshaling a nil api.Secret in UnmarshalPKIIssueResponse().

@benashz benashz requested a review from a team as a code owner March 4, 2024 15:54
@benashz benashz linked an issue Mar 4, 2024 that may be closed by this pull request
@benashz benashz force-pushed the VAULT-24551/fix-vps-handle-nil-resp branch from 1634075 to c3dd63c Compare March 4, 2024 15:57
@benashz benashz added this to the v0.5.2 milestone Mar 4, 2024
internal/vault/vault.go Outdated Show resolved Hide resolved
@benashz benashz merged commit 3cd0ac9 into main Mar 5, 2024
43 checks passed
@benashz benashz deleted the VAULT-24551/fix-vps-handle-nil-resp branch March 5, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: invalid memory address or nil pointer dereference
2 participants