Include viewer and editor RBAC roles in the chart #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new tool for syncing the roles from config/rbac to the chart templates. The script is executed as both a standalone make target and as a dependency to the manifests target.
Post review updates
benashz
deleted the
VAULT-21812/helm-chart-include-editor-viewer-rbac-roles
branch
adrianmoisey
pushed a commit
to adrianmoisey/vault-secrets-operator
that referenced
this pull request
Jan 16, 2024
Adds a new tool for syncing the roles from config/rbac to the chart templates. The script is executed as both a standalone make target and as a dependency to other targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new script for syncing the viewer/editor RBAC roles from config/rbac to the chart templates. The script is executed as both a standalone make target and as a dependency to the manifests target.
The Helm chart should now be in line with the RBAC viewer/editor roles found in the OLM package, as well as Kustomize.
Closes #448