Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPS: Sync on any update #479

Merged
merged 7 commits into from
Dec 9, 2023
Merged

VPS: Sync on any update #479

merged 7 commits into from
Dec 9, 2023

Conversation

benashz
Copy link
Collaborator

@benashz benashz commented Nov 24, 2023 •
edited
Loading

Other VPS fixes:

  • Sync whenever the destination secret is deleted and create=true
  • Sync whenever the destination secret data is modified out of band
  • Validate duration values for spec.ttl and spec.expiryOffset
  • Remove extra enqueue handler that duplicated reconciliation of a VPS resource
  • Add more test coverage for internal/helpers/hmac.go

Closes #465

@benashz benashz force-pushed the VAULT-22074/fix-pki-honour-updates-other-fixes branch 3 times, most recently from b954e3e to 7be850f Compare November 28, 2023 19:54
@benashz benashz marked this pull request as ready for review November 28, 2023 19:56
@benashz benashz requested a review from a team as a code owner November 28, 2023 19:56
@benashz
VPS: Sync on any update
f45c8b4 
Other VPS fixes:
- Sync whenever the destination secret is deleted and create=true
- Sync whenever the destination secret data is modified out of band
- Validate duration values for spec.ttl and spec.expiryOffset
- Remove extra enqueue handler that duplicated reconciliation of a VPS
  resource
@benashz benashz force-pushed the VAULT-22074/fix-pki-honour-updates-other-fixes branch from 7be850f to f45c8b4 Compare November 28, 2023 19:58
@benashz benashz added the PKI PKI secrets label Nov 28, 2023
tvoran
tvoran reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got about halfway through, just a few questions so far.

controllers/common.go Outdated Show resolved Hide resolved
controllers/vaultpkisecret_controller.go Outdated Show resolved Hide resolved
controllers/vaultpkisecret_controller.go Outdated Show resolved Hide resolved
controllers/vaultpkisecret_controller.go Outdated Show resolved Hide resolved
controllers/vaultpkisecret_controller.go Show resolved Hide resolved
kschoche
kschoche approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I left a few non-blocking comments/questions but I like the changes.
👍🏽 assuming @tvoran didn't have any blockers.

controllers/vaultpkisecret_controller.go Outdated Show resolved Hide resolved
controllers/vaultpkisecret_controller.go Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@benashz benashz added this to the v0.4.2 milestone Dec 1, 2023
@benashz benashz requested a review from tvoran December 6, 2023 02:58
@benashz benashz modified the milestones: v0.4.2, v0.5.0 Dec 7, 2023
tvoran
tvoran approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me testing locally 👍

controllers/vaultpkisecret_controller.go Show resolved Hide resolved
controllers/vaultpkisecret_controller.go Show resolved Hide resolved
@benashz benashz modified the milestones: v0.5.0, v0.4.3 Dec 9, 2023
@benashz benashz merged commit 7ede721 into main Dec 9, 2023
38 checks passed
@benashz benashz deleted the VAULT-22074/fix-pki-honour-updates-other-fixes branch December 9, 2023 21:05
@benashz benashz mentioned this pull request Dec 11, 2023
Merged
adrianmoisey pushed a commit to adrianmoisey/vault-secrets-operator that referenced this pull request Jan 16, 2024
@benashz @adrianmoisey
VPS: Sync on any update (hashicorp#479)
1922438 
Other VPS fixes:
- Sync whenever the destination secret is deleted and create is true
- Sync whenever the destination secret data is modified out of band
- Validate duration values for spec.ttl and spec.expiryOffset
- Remove extra enqueue handler that duplicated reconciliation of a VPS
  resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschoche kschoche kschoche approved these changes

@tvoran tvoran tvoran approved these changes

Assignees
No one assigned
Labels
PKI PKI secrets
Projects
None yet
Milestone
v0.4.3
Development

Successfully merging this pull request may close these issues.

Kubernetes PKI secret not updating
3 participants
@benashz @tvoran @kschoche