Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating tests for VSO in EKS #219

Merged
merged 6 commits into from
May 31, 2023
Merged

Updating tests for VSO in EKS #219

merged 6 commits into from
May 31, 2023

Conversation

gautambaghel
Copy link
Member

No description provided.

@gautambaghel gautambaghel requested a review from a team May 27, 2023 02:06
@gautambaghel gautambaghel self-assigned this May 27, 2023
@gautambaghel gautambaghel added the CI CI, builds, etc. label May 27, 2023
@gautambaghel gautambaghel added this to the v0.1.0-rc.1 milestone May 27, 2023
@gautambaghel
Copy link
Member Author

Works! And ready to be merged!

benashz
benashz approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion to consider, then 👍

README.md Outdated Show resolved Hide resolved
kschoche
kschoche approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gautambaghel gautambaghel merged commit 7d65f1f into main May 31, 2023
@gautambaghel gautambaghel deleted the VAULT-13852-ci-test-against-eks branch May 31, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

@kschoche kschoche kschoche approved these changes

@tvoran tvoran Awaiting requested review from tvoran

Assignees

@gautambaghel gautambaghel

Labels
CI CI, builds, etc.
Projects
None yet
Milestone
v0.1.0-rc.1
Development

Successfully merging this pull request may close these issues.
3 participants
@gautambaghel @kschoche @benashz