Add vaultConnectionRef to the transit auth method and provide a default #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benashz
reviewed
May 23, 2023
tvoran
reviewed
May 23, 2023
tvoran
approved these changes
May 23, 2023
gautambaghel
pushed a commit
that referenced
this pull request
May 26, 2023
…lt (#201) * Add vaultConnectionRef to the transit auth method and provide a default * remove extra unit test bits * test * remove debug code * set default explicitly in values.yaml * Add a changelog entry + sign commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
manager.controller.clientCache.storageEncryption.vaultVonnectionRefto thevalues.yamlto be used by the default-transit-auth-method.This defaults to
defaultwhich uses thedefaultVaultAuthMethod in the VSO namespace.Fixes #196
Note to reviewers: The spec of the default transit auth method is currently missing support for other auth methods beyond kubernetes. I will circle back to add that support once a couple more auth methods have landed.