VDS: Add support for specifying extra params. #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was not possible to specify the parameters when getting dynamic secrets/credentials from Vault. It should now be possible for a user to secret engine specific parameters on their VaultDynamicSecret CR
tomhjp
reviewed
May 18, 2023
config/crd/bases/secrets.hashicorp.com_vaultdynamicsecrets.yaml
Outdated
Show resolved
Hide resolved
tomhjp
reviewed
May 18, 2023
config/crd/bases/secrets.hashicorp.com_vaultdynamicsecrets.yaml
Outdated
Show resolved
Hide resolved
gautambaghel
pushed a commit
that referenced
this pull request
May 26, 2023
* VDS: Add support for specifying extra params. Previously it was not possible to specify the parameters when getting dynamic secrets/credentials from Vault. It should now be possible for a user to secret engine specific parameters on their VaultDynamicSecret CR * VDS: add support for specifying the HTTP request method (override)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was not possible to specify the parameters when getting dynamic secrets/credentials from Vault. It should now be possible for a user to secret engine specific parameters on their VaultDynamicSecret CR.