Preserve empty JSON types #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justincampbell
requested review from
chrishoffman,
caseylang,
beekus,
ryanuber,
findkim and
a team
justincampbell
force-pushed
the
json-serializer-values
branch
2 times, most recently
from
5abc923 to
675eccb
Compare
The existing behavior when specifying `serializer: :json` was to store
and return an empty Hash (`{}`) for null or empty values, including
empty arrays.
This changes the encode logic to store the JSON representation of
any given value. During decode, any valid JSON string can be decoded. We
special case `nil` or `""` (empty string) to return `nil` (instead of
`{}` previously).
This could be a breaking for applications that depend on the empty hash
== nil behavior.
justincampbell
force-pushed
the
json-serializer-values
branch
from
26f8592 to
f45e70c
Compare
findkim
approved these changes
Jun 7, 2019
justincampbell
added a commit
that referenced
this pull request
Jun 10, 2019
This adds a `:default` option to `vault_attribute`, allowing a default value to be set if the underlying value is `nil`.
```rb
vault_attribute :metadata,
serializer: :json,
default: {}
vault_attribute :access_level,
default: "readonly"
```
This enables a simple fix for applications affected by the breaking change introduced in #81 for `serialize: :json` empty values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing behavior when specifying
serializer: :jsonwas to store and return an empty Hash ({}) for null or empty values, including empty arrays or nil.This changes the encode logic to store the JSON representation of any given value. During decode, any valid JSON string can be decoded. We special case
nilor""(empty string) to returnnil(instead of{}previously).This will be a breaking change for applications that depend on the empty hash == nil behavior.