Add support for key derivation with a context #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justincampbell
requested review from
ryanuber,
chrisarcand,
davidcelis,
armon and
beekus
justincampbell
force-pushed
the
encryption-contexts
branch
from
35aa472 to
d761c73
Compare
This adds support for passing a context to Vault Transit encrypt/decrypt operations, allowing an application to specify a context per record or a `belongs_to` relation (such as a user, team, or organization). The context can be a string, or if given a proc or symbol, will generate the context for each encrypt/decrypt request. This changes the signature of `Vault::Rails.encrypt` and `Vault::Rails.decrypt`. Each had an arity of 3-4, and they now have an arity of 3 and 2 optional keyword arguments. The minor version number should be bumped on release (since the major version is still 0).
justincampbell
force-pushed
the
encryption-contexts
branch
from
d761c73 to
2a0b57a
Compare
|
@justincampbell Sorry for the late review, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for passing a context to Vault Transit encrypt/decrypt operations, allowing an application to specify a context per record or a
belongs_torelation (such as a user, team, or organization). The context can be a string, or if given a proc or symbol, will generate the context for each encrypt/decrypt request.This changes the signature of
Vault::Rails.encryptandVault::Rails.decrypt. Each had an arity of 3-4, and they now have an arity of 3 and 2 optional keyword arguments. The minor version number should be bumped on release (since the major version is still 0).