Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Rails 4.2 support #108

Merged
merged 3 commits into from
Sep 22, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -46,9 +46,6 @@ jobs:
export VAULT_VERSION=<< parameters.vault-version >>
export RAILS_VERSION=<< parameters.rails-version >>
ruby --version
# Downgrade Bundler to 1.x
gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
gem install bundler -v '< 2'
bundle -v
bundle install --jobs=4 --retry=3 --path=vendor/bundle
bundle exec rake app:db:create
@@ -79,7 +76,7 @@ workflows:
matrix:
parameters:
ruby-version: ["2.6", "2.5"]
rails-version: ["6.0.0", "5.2.0", "5.1.0", "5.0.0", "4.2.0"]
rails-version: ["6.0.0", "5.2.0", "5.1.0", "5.0.0"]
vault-version: ["1.4.2", "1.4.1", "1.4.0", "1.3.6"]
name: test-ruby-<< matrix.ruby-version >>-rails-<< matrix.rails-version >>-vault-<< matrix.vault-version >>
- build-release:
5 changes: 5 additions & 0 deletions spec/integration/rails_spec.rb
Original file line number Diff line number Diff line change
@@ -97,6 +97,11 @@
person.name = "Cinderella"
person.save!
end

it "does not register a Vault attribute as necessarily being backed by a column" do
expect(Person.attribute_names).to include("ssn")
expect(Person.column_names).not_to include("ssn")
end
end

context "lazy decrypt" do
2 changes: 1 addition & 1 deletion vault.gemspec
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ Gem::Specification.new do |s|
s.files = Dir["{app,config,db,lib}/**/*", "LICENSE", "Rakefile", "README.md"]
s.test_files = Dir["spec/**/*"]

s.add_dependency "rails", ">= 4.2"
s.add_dependency "rails", ">= 5.0"
s.add_dependency "vault", "~> 0.14"

s.add_development_dependency "bundler"