add configuration parameters to skip password rotation on import #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpcraig
changed the title
raymonstah
reviewed
Oct 24, 2023
| PasswordPolicy string `json:"password_policy,omitempty"` | ||
| LDAP *client.Config | ||
| PasswordPolicy string `json:"password_policy,omitempty"` | ||
| SkipStaticRoleImportRotation bool `json:"skip_static_role_import_rotation"` |
There was a problem hiding this comment.
It would get lengthy, but I wonder if adding some notion of password would make this more obvious.
skip_static_role_import_password_rotation. Maybe it's redundant.. thoughts?
There was a problem hiding this comment.
i don't mind adding it if people want it - i think rotation implies password in Vault contexts, so i don't think we need it
raymonstah
approved these changes
Oct 25, 2023
|
Should we add a changelog entry for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new parameter to both the ldap configuration and the static role that will skip the initial password rotation on import. While this means vault won't know the password for the static user (/ldap/static-cred/role-name won't return a password), it does mean that an admin can pre-load users into ldap (say, during an AD->LDAP migration), without immediately changing the passwords.
This setting is off by default to retain backwards compatibility.