Fix rollback error on roleset not being created properly. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Apr 12, 2018
| rolesToRemove := util.ToSet(entry.Roles) | ||
| if rs.AccountId.ResourceName() == entry.AccountId.ResourceName() { | ||
| if rs != nil && rs.AccountId.ResourceName() == entry.AccountId.ResourceName() { |
There was a problem hiding this comment.
if rs is nil is there any point in continuing on with the rest of the function? Or can we check a bit higher up and bail out early?
There was a problem hiding this comment.
If it's nil, we should actually clean up - this part checks that we don't accidently delete bindings for a roleset that still exist (i.e. someone deleted and re-added bindings but the WAL entry was not cleared yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.