Fix bats based MS Graph acceptance test #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The permissions for the MS Graph tests were incomplete, unfortunately the issue was not caught by the bats test. Essentially doing a local variable assignment from a sub-shell's stdout does not result in the test failing when the sub-shell exits with a non-zero status Summary of fixes: - bats: add support testing Azure data plane roles - terraform: ensure that 'MS Graph' test has all required permissions for the plugin to generate secrets - terraform: wait for grant assignment after `admin-consent` - bats: factor out common code to `common.sh` - bats: ensure that all variable assignment from sub-shell values fail the test in the case that the sub-shell process exits with a non-zero status - bats: add better test logging - bats: add support for specifying a custom log file - build: optionally build the plugin for the target vault docker image os/arch - build: extend to better support bats acceptance test from make
tvoran
reviewed
Dec 8, 2021
tvoran
approved these changes
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The permissions for the MS Graph tests were incomplete, unfortunately
the issue was not caught by the bats test. Essentially doing a local
variable assignment from a sub-shell's stdout does not result in the
test failing when the sub-shell exits with a non-zero status
Summary of fixes:
the plugin to generate secrets
admin-consentcommon.shtest in the case that the sub-shell process exits with a non-zero
status
os/arch