responding to feedback

backend_test.go

@@ -45,7 +45,6 @@ func getTestBackendMocked(t *testing.T, initConfig bool) (*azureSecretBackend, l
 
 	b.settings = new(clientSettings)
 	mockProvider := newMockProvider()
-	//setupMockMSGraphClient(mockProvider)
 	b.getProvider = func(s *clientSettings, p api.Passwords) (AzureProvider, error) {
 		return mockProvider, nil
 	}

path_rotate_root.go

@@ -8,8 +8,8 @@ import (
 	"fmt"
 	"time"
 
-	"github.com/google/uuid"
 	"github.com/hashicorp/go-multierror"
+	"github.com/hashicorp/go-uuid"
 	"github.com/hashicorp/vault/sdk/framework"
 	"github.com/hashicorp/vault/sdk/logical"
 )
@@ -73,7 +73,10 @@ func (b *azureSecretBackend) pathRotateRoot(ctx context.Context, req *logical.Re
 
 	app := apps[0]
 
-	uniqueID := uuid.New()
+	uniqueID, err := uuid.GenerateUUID()
+	if err != nil {
+		return nil, fmt.Errorf("failed to generate UUID: %w", err)
+	}
 
 	// This could have the same username customization logic put on it if we really wanted it here
 	passwordDisplayName := fmt.Sprintf("vault-%s", uniqueID)

provider.go

@@ -48,9 +48,6 @@ var _ AzureProvider = (*provider)(nil)
 // at this layer, the response signature may different from the Azure signature.
 type provider struct {
 	settings *clientSettings
-	// HTTP Client used to make role assignment and definition requests
-	// using new arm libraries
-	httpClient *http.Client
 
 	appClient    api.ApplicationsClient
 	spClient     api.ServicePrincipalClient
@@ -61,9 +58,6 @@ type provider struct {
 
 // newAzureProvider creates an azureProvider, backed by Azure client objects for underlying services.
 func newAzureProvider(settings *clientSettings, passwords api.Passwords) (AzureProvider, error) {
-	// @TODO see if this is still needed
-	// build clients that use the GraphRBAC endpoint
-	//userAgent := useragent.PluginString(settings.PluginEnv, userAgentPluginName)
 	httpClient := cleanhttp.DefaultClient()
 
 	cred, err := getTokenCredential(settings)
@@ -89,8 +83,7 @@ func newAzureProvider(settings *clientSettings, passwords api.Passwords) (AzureP
 	}
 
 	p := &provider{
-		settings:   settings,
-		httpClient: httpClient,
+		settings: settings,
 
 		appClient:    msGraphAppClient,
 		spClient:     msGraphAppClient,
@@ -218,7 +211,7 @@ func (p *provider) ListRoleDefinitions(ctx context.Context, scope string, filter
 	return listResp.Value, err
 }
 
-// GetRoleByID fetches the full role definition given a roleID.
+// GetRoleDefinitionByID fetches the full role definition given a roleID.
 func (p *provider) GetRoleDefinitionByID(ctx context.Context, roleID string) (result armauthorization.RoleDefinitionsClientGetByIDResponse, err error) {
 	return p.rdClient.GetByID(ctx, roleID, nil)
 }