Remove dependency on github.com/microsoftgraph/msgraph-sdk-go #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only use msgraph-sdk-go for a handful of calls, and they are relatively straightforward HTTP calls. This code still uses the Microsoft packages for authentication, which is the trickier part. I'm having trouble getting the tests to pass consistently, but I always have trouble with these tests. I compiled the Vault binary with this change only, and it reduces the size of the Vault binary from 360 MB to 264 MB.
fairclothjm
reviewed
Nov 2, 2023
|
|
||
| apps := resp.GetValue() | ||
| if len(apps) == 0 { | ||
| resp, err := http.DefaultClient.Do(request) |
There was a problem hiding this comment.
Should we use https://github.com/hashicorp/go-cleanhttp?
There was a problem hiding this comment.
Yep! I rushed this out, but if we intended to go this route, I'd refactor this to use a common http client and DRY a few things.
But, it sounds like we're looking to use the msgraph SDK in more places, so merging this wouldn't really change anything. I'll close for now but keep the branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only use msgraph-sdk-go for a handful of calls, and they are relatively straightforward HTTP calls.
This code still uses the Microsoft packages for authentication, which is the trickier part.
I'm having trouble getting the tests to pass consistently, but I always have trouble with these tests.
I compiled the Vault binary with this change only, and it reduces the size of the Vault binary from 360 MB to 264 MB.