fix endless loop in logs on login error (#170)

* fix endless loop in logs on login error * changelog * Update CHANGELOG.md
hashicorp · Oct 15, 2024 · aff18aa · aff18aa
1 parent 6d8230d
commit aff18aa
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 ## Unreleased
 
+## v0.19.1
+
+BUGS:
+
+* fix an endless loop of warning spamming the logs on login error (https://github.com/hashicorp/vault-plugin-auth-azure/pull/170)
+
 ## v0.19.0
 
 IMPROVEMENTS:

diff --git a/path_login.go b/path_login.go
@@ -450,6 +450,9 @@ func (b *azureAuthBackend) verifyResource(ctx context.Context, subscriptionID, r
 				if err != nil {
 					// don't fail the whole auth, but note that a page failed to load:
 					b.Logger().Warn("couldn't load next page for", "resource_group", rg, "error", err.Error())
+
+					// ensure we don't loop forever
+					break
 				}
 				for _, id := range page.Value {
 					if id.Properties != nil && id.Properties.ClientID != nil {