fix endless loop in logs on login error (#170)

* fix endless loop in logs on login error * changelog * Update CHANGELOG.md
hashicorp · Oct 15, 2024 · 0764f81 · 0764f81
1 parent 3a9ef8d
commit 0764f81
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,15 +2,17 @@
 
 ## v0.18.1
 
-IMPROVEMENTS:
-* Bump github.com/coreos/go-oidc to v3 (https://github.com/hashicorp/vault-plugin-auth-azure/pull/157)
+BUGS:
+
+* fix an endless loop of warning spamming the logs on login error
 
 ## v0.18.0
 
 FEATURES:
 * Add support for Workload Identify Federation (https://github.com/hashicorp/vault-plugin-auth-azure/pull/151)
 
 IMPROVEMENTS:
+* Bump github.com/coreos/go-oidc to v3 (https://github.com/hashicorp/vault-plugin-auth-azure/pull/157)
 * Updated dependencies: (https://github.com/hashicorp/vault-plugin-auth-azure/pull/154)
 * Updated dependencies:
   * `github.com/Azure/azure-sdk-for-go/sdk/azcore` v1.9.1 -> v1.10.0

diff --git a/path_login.go b/path_login.go
@@ -437,6 +437,9 @@ func (b *azureAuthBackend) verifyResource(ctx context.Context, subscriptionID, r
 				if err != nil {
 					// don't fail the whole auth, but note that a page failed to load:
 					b.Logger().Warn("couldn't load next page for", "resource_group", rg, "error", err.Error())
+
+					// ensure we don't loop forever
+					break
 				}
 				for _, id := range page.Value {
 					if id.Properties != nil && id.Properties.ClientID != nil {