Add configurable probe values #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tom Proctor <[email protected]>
Co-authored-by: Tom Proctor <[email protected]>
tvoran
reviewed
Sep 14, 2020
Co-authored-by: Theron Voran <[email protected]>
tvoran
reviewed
Sep 14, 2020
tvoran
approved these changes
Sep 15, 2020
This was referenced Oct 16, 2020
Merged
Comment on lines
+240
to
+245
| # How often (in seconds) to perform the probe | ||
| periodSeconds: 5 | ||
| # Minimum consecutive successes for the probe to be considered successful after having failed | ||
| successThreshold: 1 | ||
| # Number of seconds after which the probe times out. | ||
| timeoutSeconds: 3 |
There was a problem hiding this comment.
was this desired to swap period and timeout values? It was timeout:5 and period:3 before that PR.
There was a problem hiding this comment.
Yeah, as discussed here: #387 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes hardcoded probe values configurable with some defaults out of the box so users can configure readiness/liveness probes for their environment.