Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates/server): ingress has default paths of / #224

Merged
merged 2 commits into from
Apr 9, 2020
Merged

fix(templates/server): ingress has default paths of / #224

merged 2 commits into from
Apr 9, 2020

Conversation

jaredallard
Copy link
Contributor

What this PR does: Fixes an empty array for paths resulting in a generation error.

Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Ingress.spec.rules[0].http): missing required field "paths" in io.k8s.api.extensions.v1beta1.HTTPIngressRuleValue

Another way of doing this is just setting paths to be have / as a element, but I don't like relying on values.yaml personally.

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 11, 2020

CLA assistant check
All committers have signed the CLA.

It's been awhile since I wrote Helm templates :/
@tvoran tvoran added bug Something isn't working chart Area: helm chart labels Mar 14, 2020
@jasonodonnell jasonodonnell self-requested a review April 9, 2020 16:48
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jasonodonnell jasonodonnell merged commit 27a3a76 into hashicorp:master Apr 9, 2020
radudd pushed a commit to radudd/vault-helm that referenced this pull request Jun 5, 2020
* fix(templates/server): ingress has default paths of /

* fix: array -> list

It's been awhile since I wrote Helm templates :/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chart Area: helm chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants