Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for external vault #207

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Added support for external vault #207

merged 2 commits into from
Feb 21, 2020

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Feb 20, 2020

Uses Values.injector.externalVaultAddr to control the vault address
env variable and server yaml rendering.

If injector.externalVaultAddr is empty, both the injector and vault are deployed, with the injector using the local vault. If injector.externalVaultAddr is not empty, only the injector is deployed, and it uses the vault at the address specified in injector.externalVaultAddr.

Related to #167, #173, #202

Uses Values.injector.externalVaultAddr to control the vault address
env variable and server yaml rendering.
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tvoran tvoran merged commit 2b2b0dd into master Feb 21, 2020
@tvoran tvoran deleted the external-vault branch February 21, 2020 16:16
radudd pushed a commit to radudd/vault-helm that referenced this pull request Jun 5, 2020
Uses Values.injector.externalVaultAddr to control the vault address
env variable and server yaml rendering.

If injector.externalVaultAddr is empty, both the injector and vault
are deployed, with the injector using the local vault. If
injector.externalVaultAddr is not empty, only the injector is
deployed, and it uses the vault at the address specified in
injector.externalVaultAddr.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to deploy injector only Allow injector to read from remote vault
2 participants