Add support for priorityClassName #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Bump |
|
Hey, thanks for the bump. Missed the notification for your previous comment. Rebased and added unit tests. |
|
Resolved new merge conflict, also bump @jasonodonnell. |
|
@bycEEE can you fix the new merge conflict and ping approvers again? Would love to see this get added and its so close! |
|
@InAnimaTe fixed! |
Awesome, you da man! @jasonodonnell I think this is ready to go in!! |
jasonodonnell
added a commit
that referenced
this pull request
May 5, 2020
This reverts commit 2af6f9b.
jasonodonnell
added a commit
that referenced
this pull request
May 5, 2020
|
I didn't notice that a colleague merged a similar feature implementing priorityClassName's on the pods, so this caused a collision. I reverted this merge, however, this feature has been implemented and merged. You can find this in the next vault-helm release. Thanks! |
radudd
pushed a commit
to radudd/vault-helm
that referenced
this pull request
Jun 5, 2020
* Add support for priorityClassName * Add unit tests * Remove comment * Update comment, accidentally deleted comment * Remove whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.