-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm cannot install the chart if the global setting is disabled #306
Comments
I think it's related to this Helm issue: helm/helm#4670 TL;DR: Helm assumes it's invalid to deploy no resources. Additionally, Helm assumes it's invalid to deploy only Secrets/ConfigMaps/Jobs. My issue is that I can't deploy only an injector with such global:
enabled: false
injector:
authPath: kubernetes/cluster-beta
enabled: true
externalVaultAddr: https://vault.example.com
logFormat: json
priorityClassName: required
resources:
limits:
cpu: 20m
memory: 100Mi
requests:
cpu: 5m
memory: 50Mi
revokeOnShutdown: true
One of proposed workarounds is to always deploy a dummy |
The documentation says you can disable the global setting and enable components selectively: https://www.vaultproject.io/docs/platform/k8s/helm/configuration#enabled However, this is not true. It will never work, as the chart checks for both values to be
|
@bitfactory-henno-schooljan that's true. When I created a chart dummy deployment, only the deployment was created, so it was not a Helm bug there. I ended up reading the source of this Helm chart and came up with this (that's my complete values.yaml for injector-only setup, nothing more, nothing less): injector:
enabled: true
externalVaultAddr: https://vault.example.com # This is the important part here
authPath: kubernetes/cluster-beta
logFormat: json
revokeOnShutdown: true
namespaceSelector: null
resources:
requests:
cpu: 5m
memory: 50Mi
limits:
cpu: 20m
memory: 100Mi
|
As the above comment says, the documentation is not accurately reflecting the actual logic on the chart. Is this intentional? Which one is correct? In the mean time I will try @krzysztof-miemiec's workaround. |
Hi folks, it appears the documentation is indeed not correct when it says individual components can be enabled when In the meantime, the docs for |
Hi! |
I believe this has been fixed after #703 -- if it hasn't been, please feel free to re-open. |
If the global settings are disabled but the individual settings are enabled, the helm doesn't seem to install the chart, with the
error: no objects visited
The text was updated successfully, but these errors were encountered: